TURN OFF PRIVATE BROWSING IN FIREFOX PATCH
TURN OFF PRIVATE BROWSING IN FIREFOX UPGRADE

No need to check the member, just set it to null.Other studies conducted by the Pew Research Center and the privacy-protective search engine company DuckDuckGo have similar findings. > + mPrivateBrowsingDBConnection = nullptr

No new NS_ASSERTIONs please, use +4416,5 + if (aIsPrivateBrowsing) > + NS_ASSERTION(quotaManager, 'This should never fail!') > + QuotaManager* quotaManager = QuotaManager::Get() What about doing it in reverse, then you don't have to negate +4415,5 } > + return aStorageService->OpenDatabaseWithFileURL(aFileURL, aConnection) ::: +4312,5 mozIStorageConnection** aConnection) Otherwise it will be harder to work on other things that are needed to finish private browsing support. You should check/fix that before anything else. I think the number one issue is the way how you access stuff on different threads.

TURN OFF PRIVATE BROWSING IN FIREFOX UPGRADE

It's very important internal quota manager database file and the information stored there is needed to decide if we need to upgrade /storage or not. Pfff !, Do you really want to open this database in memory ? > + rv = ss->OpenPrivateBrowsingDatabase(storageFile, getter_AddRefs(connection)) NsIPrincipal now contains the private browsing info, so it should add it to origin attributes I believe, so the origin directory will be separate from 'normal' origin.ДЄnyway, these private browsing origins will need to be cleaned up at next temporary storage initialization. > + // TODO: If we're in private browsing mode, we need the file manager to be ::: +20920,5 MOZ_ASSERT(databaseFilePath = mDatabaseFilePath)

TURN OFF PRIVATE BROWSING IN FIREFOX PATCH

Patch 1 (v1) - WIP: Store Quota Manager/IDB sqlite DBs in memory during private browsing Baku, could you look over this and let me know if general idea here is correct? If you have any advice on what I'm doing wrong with the observer handling on LazyIdleThread too, that'd be great.Д¬omment on attachment 8793198 Otherwise, the idea seems to work, in that I can close and open tabs and we keep the in-memory databases alive. I've co-opt'd the QuotaManager ShutdownObserver, but for some reason firing the runnable to mBackgroundThread causes LazyIdleThread to hit the 'Mismatched calls to observer methods!' error at. Right now my major issue is cleaning up databases on the last-pb-context-exited observer event. Basically, if we try to open a database while in private browsing mode, it's opened in memory, and we keep a cache of connections to all the different database FileURLs in QuotaManager until the private browsing session ends. Splinter Review This patch is still work in progress, but captures the general idea of what I'm going for. Patch 1 (v1) - WIP: Store Quota Manager/IDB sqlite DBs in memory during private browsing (obsolete) That would make it possible to detect if you were in PB mode, whichДisabling particular parts of the api seems troublesome for the same compability issue, it is really hard to have a sensible fallback for authors especially since idb it is somewhat recommended that authors use libraries over indexeddb to interact with its api, which then puts the onus on the authors of those libraries to provide memory fallbacks only for firefox in private browsing. We would have to disable things like files in IndexedDB, which However with indexedDB becoming more popular this is beginning to become more problematic, its very hard to sensible fallback an indexeddb based application without the API and we are seeing more and more reports of people stuck on what to do to handle firefox private browsing. Yup with PouchDB we are seeing we can detect the failure to open the database inside onerror fine.

Turn off private browsing in firefox